Netherite-Public/ZNPCsPlus
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity

update viewers list before showing the npc to prevent the show/hide methods from being called multiple times by the processor task when the method needs extra time to grab skins which causes some problems including multiple teams being created resulting in client warnings/kicks on BungeeCord

Browse source
This commit is contained in:
Pyrbu 2023-07-25 03:14:41 +02:00
parent fef68e663b
commit a92de1817d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugin/src/main/java/lol/pyr/znpcsplus/util/Viewable.java
View file

@ -27,14 +27,14 @@ public abstract class Viewable {
public void show(Player player) { public void show(Player player) {
if (viewers.contains(player)) return; if (viewers.contains(player)) return;
UNSAFE_show(player);
viewers.add(player); viewers.add(player);
UNSAFE_show(player);
} }
public void hide(Player player) { public void hide(Player player) {
if (!viewers.contains(player)) return; if (!viewers.contains(player)) return;
UNSAFE_hide(player);
viewers.remove(player); viewers.remove(player);
UNSAFE_hide(player);
} }
protected void UNSAFE_hideAll() { protected void UNSAFE_hideAll() {