From 365d0e7ca5c91bf4050f679371af642a88c279e8 Mon Sep 17 00:00:00 2001 From: 3328429240 <3328429240@qq.com> Date: Tue, 22 Jul 2025 20:26:57 +0800 Subject: [PATCH] refactor: Remove redundant V1_21_8PacketFactory class MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The setupPacketFactory function automatically selects the highest compatible version using fallback logic, making the empty V1_21_8PacketFactory unnecessary. Minecraft 1.21.8 will now use V1_21_3PacketFactory automatically. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .promptx/pouch.json | 28 +++++++++++++++++++ .promptx/resource/project.registry.json | 17 +++++++++++ .../java/lol/pyr/znpcsplus/ZNpcsPlus.java | 1 - .../packets/V1_21_8PacketFactory.java | 24 ---------------- 4 files changed, 45 insertions(+), 25 deletions(-) create mode 100644 .promptx/pouch.json create mode 100644 .promptx/resource/project.registry.json delete mode 100644 plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_21_8PacketFactory.java diff --git a/.promptx/pouch.json b/.promptx/pouch.json new file mode 100644 index 0000000..7ee3f63 --- /dev/null +++ b/.promptx/pouch.json @@ -0,0 +1,28 @@ +{ + "currentState": "initialized", + "stateHistory": [ + { + "from": "initial", + "command": "init", + "timestamp": "2025-07-10T13:21:04.186Z", + "args": [ + { + "workingDirectory": "/home/wangmeng123/znpcsplus", + "ideType": "cursor" + } + ] + }, + { + "from": "initialized", + "command": "init", + "timestamp": "2025-07-10T13:21:38.336Z", + "args": [ + { + "workingDirectory": "/home/wangmeng123/ZNPCsPlus-2.X", + "ideType": "cursor" + } + ] + } + ], + "lastUpdated": "2025-07-10T13:21:38.393Z" +} diff --git a/.promptx/resource/project.registry.json b/.promptx/resource/project.registry.json new file mode 100644 index 0000000..e02876c --- /dev/null +++ b/.promptx/resource/project.registry.json @@ -0,0 +1,17 @@ +{ + "version": "2.0.0", + "source": "project", + "metadata": { + "version": "2.0.0", + "description": "project 级资源注册表", + "createdAt": "2025-07-10T13:21:38.381Z", + "updatedAt": "2025-07-10T13:21:38.383Z", + "resourceCount": 0 + }, + "resources": [], + "stats": { + "totalResources": 0, + "byProtocol": {}, + "bySource": {} + } +} diff --git a/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java b/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java index a103ab4..ed39bb4 100644 --- a/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java +++ b/plugin/src/main/java/lol/pyr/znpcsplus/ZNpcsPlus.java @@ -234,7 +234,6 @@ public class ZNpcsPlus { versions.put(ServerVersion.V_1_19_3, LazyLoader.of(() -> new V1_19_3PacketFactory(scheduler, packetEvents, propertyRegistry, textSerializer, configManager))); versions.put(ServerVersion.V_1_20_2, LazyLoader.of(() -> new V1_20_2PacketFactory(scheduler, packetEvents, propertyRegistry, textSerializer, configManager))); versions.put(ServerVersion.V_1_21_3, LazyLoader.of(() -> new V1_21_3PacketFactory(scheduler, packetEvents, propertyRegistry, textSerializer, configManager))); - versions.put(ServerVersion.V_1_21_8, LazyLoader.of(() -> new V1_21_8PacketFactory(scheduler, packetEvents, propertyRegistry, textSerializer, configManager))); ServerVersion version = packetEvents.getServerManager().getVersion(); if (versions.containsKey(version)) return versions.get(version).get(); diff --git a/plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_21_8PacketFactory.java b/plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_21_8PacketFactory.java deleted file mode 100644 index 0c92e4f..0000000 --- a/plugin/src/main/java/lol/pyr/znpcsplus/packets/V1_21_8PacketFactory.java +++ /dev/null @@ -1,24 +0,0 @@ -package lol.pyr.znpcsplus.packets; - -import com.github.retrooper.packetevents.PacketEventsAPI; -import lol.pyr.znpcsplus.config.ConfigManager; -import lol.pyr.znpcsplus.entity.EntityPropertyRegistryImpl; -import lol.pyr.znpcsplus.scheduling.TaskScheduler; -import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer; -import org.bukkit.plugin.Plugin; - -/** - * PacketFactory implementation for Minecraft 1.21.8. - * - * Since 1.21.8 is a hotfix release focusing on graphical and stability improvements - * without major protocol changes, this factory inherits all functionality from - * V1_21_3PacketFactory. Future version-specific optimizations can be added here - * if needed. - */ -public class V1_21_8PacketFactory extends V1_21_3PacketFactory { - public V1_21_8PacketFactory(TaskScheduler scheduler, PacketEventsAPI packetEvents, - EntityPropertyRegistryImpl propertyRegistry, LegacyComponentSerializer textSerializer, - ConfigManager configManager) { - super(scheduler, packetEvents, propertyRegistry, textSerializer, configManager); - } -} \ No newline at end of file