Netherite-Public/EntityLib
5
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #42 from neziw/fix-resources-leak

Browse source 
Ensure InputStream and BufferedReader are closed properly
This commit is contained in:
Tofaa 2025-08-06 06:19:47 +04:00 committed by GitHub
commit 8ac2119c67
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
api/src/main/java/me/tofaa/entitylib/utils/GithubUpdater.java
View file

@ -57,18 +57,19 @@ public final class GithubUpdater {
URL url = new URL("https://api.github.com/repos/" + org + "/" + repo + "/releases/latest"); URL url = new URL("https://api.github.com/repos/" + org + "/" + repo + "/releases/latest");
URLConnection connection = url.openConnection(); URLConnection connection = url.openConnection();
connection.addRequestProperty("User-Agent", "Mozilla/5.0"); connection.addRequestProperty("User-Agent", "Mozilla/5.0");
InputStreamReader isr = new InputStreamReader(connection.getInputStream());
BufferedReader reader = new BufferedReader(isr);
String response = reader.readLine();
JsonObject json = AdventureSerializer.getGsonSerializer().serializer().fromJson(response, JsonObject.class);
reader.close(); try (
isr.close(); InputStreamReader isr = new InputStreamReader(connection.getInputStream());
BufferedReader reader = new BufferedReader(isr)
) {
String response = reader.readLine();
JsonObject json = AdventureSerializer.getGsonSerializer().serializer().fromJson(response, JsonObject.class);
if (json.has("tag_name")) { if (json.has("tag_name")) {
return PEVersion.fromString(json.get("tag_name").getAsString().replaceFirst("^[vV]", "")); return PEVersion.fromString(json.get("tag_name").getAsString().replaceFirst("^[vV]", ""));
}
throw new IOException("Could not find name attribute in github api fetch");
} }
throw new IOException("Could not find name attribute in github api fetch");
} }
@Deprecated @Deprecated